[style] add comment

src/broker/modules/matching.go

@@ -8,24 +8,30 @@ import (
 )
 
 type match_manager struct {
-	match_count int
+	match_count int // Number of successful matches
 }
 
-// Matching -> Return (list of IP addresses of matched subs, Pub Msg, error)
+// Matching operation method
+// 1. Traverse TopicList for match (msg.topic == topicNode.topic)
+// 2. Traverse TopicNode.ValueList for match (msg.value <operator> valueNode.value)
+// 3. Add ipaddr to ipList when successful matching
+// 4. Add ipaddr to ipList when range matching
+// 5. Delete Duplicated Ipaddrs
+// @Return (list of IP addresses of matched subs, Pub Msg, error)
 func (moscato *Moscato) Matching(msg MsgUnit) {
-	//msg := moscato.queue.pop(true)
+
 	topic := msg.(PublishMsg).Topic
 	value := msg.(PublishMsg).Value
 	sub_mng := moscato.SubscriptionManager
 
-	// listß
-	ret := make([]string, 0)
+	// iplist for return
+	ipList := make([]string, 0)
 
 	// list for matched range subscriptions
 	big := make([]int, 0)
 	small := make([]int, 0)
 
-	// 1. Find (topicNode[Topic] == msg.Topic) Node
+	// Find (topicNode[Topic] == msg.Topic) Node
 	topicPtr := sub_mng.list
 	pos := topicPtr.getTopicNodePos(topic)
 
@@ -33,7 +39,7 @@ func (moscato *Moscato) Matching(msg MsgUnit) {
 	if pos == nil {
 		moscato.SendQueue <- myType{nil, msg, errors.New("Don't Exist Matching Topic")}
 	} else {
-		// 2. Traverse all valueNode -> and Match
+		// Traverse all valueNode -> and Match
 		valPtr := pos.list.head
 		for valPtr != nil {
 			compare := Compare(valPtr.val, value)
@@ -44,14 +50,14 @@ func (moscato *Moscato) Matching(msg MsgUnit) {
 				for i := 0; i < len(valPtr.single2sub_b); i++ {
 					sub := valPtr.single2sub_b[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 
 				// (2) case : >=
 				for i := 0; i < len(valPtr.single2sub_eb); i++ {
 					sub := valPtr.single2sub_eb[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 				// range : { >, >= }
 
@@ -75,14 +81,14 @@ func (moscato *Moscato) Matching(msg MsgUnit) {
 				for i := 0; i < len(valPtr.single2sub_s); i++ {
 					sub := valPtr.single2sub_s[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 
 				// (2) case : <=
 				for i := 0; i < len(valPtr.single2sub_es); i++ {
 					sub := valPtr.single2sub_es[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 
 				// range : { <, <= }
@@ -106,21 +112,21 @@ func (moscato *Moscato) Matching(msg MsgUnit) {
 				for i := 0; i < len(valPtr.single2sub_es); i++ {
 					sub := valPtr.single2sub_es[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 
 				// (2) case : >=
 				for i := 0; i < len(valPtr.single2sub_eb); i++ {
 					sub := valPtr.single2sub_eb[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 
 				// (3) case : ==
 				for i := 0; i < len(valPtr.single2sub_e); i++ {
 					sub := valPtr.single2sub_e[i]
 					ip := sub_mng.sub2ip[sub]
-					ret = append(ret, ip)
+					ipList = append(ipList, ip)
 				}
 
 				// range : { <=, >= }
@@ -142,17 +148,26 @@ func (moscato *Moscato) Matching(msg MsgUnit) {
 		}
 
 		// Add the intersection IP address of two sets (large and small) to the return list
-		hash := intersect.Hash(small, big)
-		list := reflect.ValueOf(hash)
+		intersectSubnumbers := intersect.Hash(small, big)
+		list := reflect.ValueOf(intersectSubnumbers)
 		for i := 0; i < list.Len(); i++ {
 			sub := list.Index(i).Interface().(int)
 			ip := sub_mng.sub2ip[sub]
-			ret = append(ret, ip)
+			ipList = append(ipList, ip)
 		}
-		//fmt.Println("big = ", big)
-		//fmt.Println("small = ", small)
-		//fmt.Println("ret = ", ret)
 		moscato.MatchingManager.match_count++
-		moscato.SendQueue <- myType{ret, msg, nil}
+
+		// To delete Duplicated Ipaddr
+		keys := make(map[string]bool)
+		retIpList := []string{}
+		for _, val := range ipList {
+			if _, saveVal := keys[val]; !saveVal{
+				keys[val] = true
+				retIpList = append(retIpList, val)
+			}
+		}
+
+		// Return {IpaddressList, PubMsg, ErrorMsg} to SendQueue
+		moscato.SendQueue <- myType{retIpList, msg, nil}
 	}
-}
+}